Centralize SQL benchmark matrices in bench-orchestrator - #9017
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
myrrc
approved these changes
Jul 27, 2026
Member
Author
|
seems like CI completely fell over, i dont think its this PR here |
connortsui20
marked this pull request as ready for review
July 27, 2026 17:33
AdamGS
approved these changes
Jul 27, 2026
AdamGS
left a comment
AdamGS
left a comment
Contributor
There was a problem hiding this comment.
Without carefully checking the matrixes, this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes: #4935
Revived from: #8801
SQL benchmark coverage was spread across large workflow JSON matrices and difficult to audit.
What changes are included in this PR?
Moves benchmark coverage into one typed Python catalog.
vx-bench matrix <preset>validates and renders it for GitHub Actions; the surrounding modules only model, validate, and render the catalog.The
pr,pr-full,develop, andnightlyoutputs remain unchanged.